Skip to content

Commit

Permalink
Remove duplicate stop() calls and rename to --report-gil-contention
Browse files Browse the repository at this point in the history
Co-authored-by: Lawrence Mitchell <[email protected]>
  • Loading branch information
pentschev and wence- authored Oct 13, 2023
1 parent 2accb9c commit 700af6b
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion ucp/benchmarks/backends/tornado.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ async def run(self) -> bool:

if self.args.report_gil_contention:
knocker.stop()
knocker.stop()

self.queue.put(times)
if self.args.report_gil_contention:
Expand Down
1 change: 0 additions & 1 deletion ucp/benchmarks/backends/ucp_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,6 @@ def op_completed():

if self.args.report_gil_contention:
knocker.stop()
knocker.stop()
if self.args.cuda_profile:
xp.cuda.profiler.stop()

Expand Down
2 changes: 1 addition & 1 deletion ucp/benchmarks/send_recv.py
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ def parse_args():
except ImportError:
raise RuntimeError(
"Could not import `gilknocker`. Make sure it is installed or "
"remove the `--measure-gil-contention` argument."
"remove the `--report-gil-contention` argument."
)

return args
Expand Down

0 comments on commit 700af6b

Please sign in to comment.