Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for python 3.11 #176
add support for python 3.11 #176
Changes from 3 commits
ac20007
dbfc993
c32c724
ed8590a
ea9c6cd
e678683
baf15bd
d227937
b15f36c
115ad5a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s reshuffle these a bit. I want one configuration to be amd64 + latest Python + latest CUDA. Currently it seems only ARM has Python 3.11 jobs. I would also tilt the distribution of versions to be evenly weighted, it seems like the matrix tests 3.9 and 3.10 more than 3.11 (I didn’t do an exact count).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking @bdice .
This PR does currently have a Python 3.11 AMD job for
wheels-test
... but just on PRs.Definitely agree the mix across Python versions is uneven right now, I'll fix that.
Before I go further with this... would you consider this change I just put up?
#177
Based on my experience here and in #166, I think it's worth taking a minute to re-sorting these matrices so they're easier to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright @bdice whenever you have time, could you please take another look?
(and @msarahan @AyodeAwe @KyleFromNVIDIA if you'd like another chance to review now that changes have been made)
By my count, on the current state of this branch we have the following mix:
And the
conda-python-tests (pr)
andwheel-test (pr)
both have the combination "amd64 + latest Python + latest CUDA".I've still preserved the same absolute number of test jobs as
branch-24.04
.I've also updated the description, with tests from these two PRs: