Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove HTML builds of librmm (#1415)" #1604

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jul 10, 2024

Description

This reverts commit 77b5500.

See: rapidsai/docs#517 (review)

We need to have librmm docs published in order to enable cross-linking of librmm from libcudf docs.

From discussion with @raydouglass, we don't need to link to them publicly on docs.rapids.ai, as they are already included in the rmm docs (both C++ and Python). The librmm docs will just be used to cross-reference from libcudf docs.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner July 10, 2024 17:07
@bdice bdice requested a review from raydouglass July 10, 2024 17:07
@github-actions github-actions bot added cpp Pertains to C++ code ci labels Jul 10, 2024
@vyasr vyasr added doc Documentation non-breaking Non-breaking change labels Jul 15, 2024
@vyasr
Copy link
Contributor

vyasr commented Jul 15, 2024

/merge

@rapids-bot rapids-bot bot merged commit 4299608 into rapidsai:branch-24.08 Jul 15, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci cpp Pertains to C++ code doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants