-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all internal usage of get_upstream
with get_upstream_resource
#1491
Replace all internal usage of get_upstream
with get_upstream_resource
#1491
Conversation
…rce` We want to get away from raw resources, so prepare deprecation of it by replacing all internal usages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes to bake sure this doesn't merge before the downstream PRs are merged.
@miscco if you would like to merge this before downstream PRs, you could move the deprecations to a separate PR that won't be merged yet. |
I'd favor splitting this PR into the new functions and then the deprecations, it does seem to help with moving the work along. |
As far as I can see, there are two occurrences of rapidsai/cudf#15203 The only one I am not 100% sure how to get rid of is one other in raft where it explicitly checks whether a resource of of a given type, which is neither possible with the current Given that those PRs are very small and limited in scope I believe we can wait a few days getting them in |
Also the RMM Cython needs to be updated, and all uses of its current method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny doc nitpick.
We decided that this didn't seem to be necessary, since, for now, the Cython |
/merge |
We want to get away from raw resources, so prepare deprecation of it by replacing all internal usages
This PR relies on preparation in downstream repositories