Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DO NOT MERGE) test shared-workflow changes #1490

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Feb 28, 2024

Description

Testing the changes in rapidsai/shared-workflows#182.

I added an exit 1 for the wheel tests. Ideally, we'll see the following:

  • Python 3.11 wheel tests marked successful
  • non-Python-3.11 wheel tests marked as failed
  • merging blocked

Notes for Reviewers

I removed the DO NOT MERGE label so that Label Checker will pass, since we want to test that the pr-builder workflow is failing for exactly the reasons we expect it to, and no others.

But don't actually merge this.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added 5 - DO NOT MERGE Hold off on merging; see PR for details bug Something isn't working non-breaking Non-breaking change and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Feb 28, 2024
@jameslamb jameslamb changed the title test shared-workflow changes (DO NOT MERGE) test shared-workflow changes Feb 28, 2024
@vyasr
Copy link
Contributor

vyasr commented Feb 29, 2024

Closing, we now know that the current workflow filtering produces the expected behaviors for all matrix jobs.

@vyasr vyasr closed this Feb 29, 2024
@jameslamb jameslamb deleted the test-non-python-3.11-failures branch February 29, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants