Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11 #1469

Merged
merged 14 commits into from
Feb 27, 2024
Merged

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Feb 20, 2024

Description

Contributes to rapidsai/build-planning#3

This PR adds support for Python 3.11.

Notes for Reviewers

This is part of ongoing work to add Python 3.11 support across RAPIDS.

The Python 3.11 CI workflows introduced in rapidsai/shared-workflows#176 are optional... they are not yet required to run successfully for PRs to be merged.

This PR can be merged once all jobs are running successfully (including the non-required jobs for Python 3.11). The CI logs should be verified that the jobs are building and testing with Python 3.11.

See rapidsai/shared-workflows#176 for more details.

@jameslamb jameslamb added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Feb 20, 2024
@github-actions github-actions bot added Python Related to RMM Python API conda labels Feb 20, 2024
.github/workflows/build.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In many repos, the README also lists some versions. We might need to do these by hand, even if we automate the rest.

Note: RMM is supported only on Linux, and only tested with Python versions 3.9 and 3.10.

@jameslamb
Copy link
Member Author

We might need to do these by hand, even if we automate the rest.

Thanks! Updated that for this repo in 2da47a1. Looked for other references and didn't find any others that need to be updated:

git grep -E '3\.9'
git grep -E '3\.10'

.github/workflows/build.yaml Outdated Show resolved Hide resolved
@jameslamb jameslamb marked this pull request as ready for review February 26, 2024 23:13
@jameslamb jameslamb requested review from a team as code owners February 26, 2024 23:13
@KyleFromNVIDIA
Copy link
Contributor

/merge

@bdice
Copy link
Contributor

bdice commented Feb 27, 2024

/merge

@rapids-bot rapids-bot bot merged commit e2f54a0 into rapidsai:branch-24.04 Feb 27, 2024
56 checks passed
@jameslamb jameslamb deleted the python-3.11 branch February 27, 2024 16:52
@jakirkham
Copy link
Member

Since Python 3.11 requires NumPy 1.23 at a minimum ( rapidsai/cucim#704 (comment) ), updating NumPy requirements in PR: #1488

@jakirkham jakirkham mentioned this pull request Feb 28, 2024
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Feb 28, 2024
As NumPy 1.23 is needed for Python 3.11 support, go ahead and bump the minimum NumPy version used by RMM to match that.

xref: #1469

<hr>

Authors:
  - https://github.com/jakirkham

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #1488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants