Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove references to setup.py in docs #1420

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 5, 2024

Description

Removes remaining references to setup.py in documentation.

This project no longer has a setup.py as of its switch to pyproject.toml + scikit-build-core (see #1287, #1300).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

How I tested this

Built the library in editable mode and ran its tests on a machine w/ 8 V100s.

nvidia-smi output (click me)
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 525.105.17   Driver Version: 525.105.17   CUDA Version: 12.0     |
|-------------------------------+----------------------+----------------------+
mamba env create \
    --name rmm-dev \
    -f ./conda/environments/all_cuda-120_arch-x86_64.yaml

source activate rmm-dev

python -m pip install -e ./python

pytest -v

Saw all the tests pass:

... ==== 773 passed, 5 skipped in 48.82s ...

To test that editable was working, added the following:

echo "print('beep boop')" >> ./python/rmm/__init__.py
python -c "import rmm"
# beep boop

Confirmed that this caught all references to setup.py like this:

git grep -E 'setup\.py'

Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@harrism harrism added doc Documentation Python Related to RMM Python API improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed improvement Improvement / enhancement to an existing function labels Jan 8, 2024
@harrism
Copy link
Member

harrism commented Jan 8, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9265976 into rapidsai:branch-24.02 Jan 8, 2024
47 checks passed
@jameslamb jameslamb deleted the no-setup-py branch January 8, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change Python Related to RMM Python API
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants