Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding required Cookie Banner #391

Closed
wants to merge 0 commits into from
Closed

Conversation

exactlyallan
Copy link
Member

Per #387 request

@exactlyallan exactlyallan added the 3 - Ready for Review Ready for review by team label Aug 13, 2024
@exactlyallan exactlyallan self-assigned this Aug 13, 2024
@exactlyallan exactlyallan requested a review from a team as a code owner August 13, 2024 00:34
@bdice
Copy link
Contributor

bdice commented Aug 13, 2024

@exactlyallan Can you rebase this? It shows five commits. Also your last commit appears as unverified…

@exactlyallan
Copy link
Member Author

@bdice ...syncing my fork in the UI does not do what I think it does. Ill redo.

@bdice
Copy link
Contributor

bdice commented Aug 13, 2024

@exactlyallan I think part of the problem is that you need to create a branch on your fork, like exactlyallan:add-cookie-banner rather than pushing to your fork’s main branch and opening the PR from your fork’s main branch. You should never commit to your fork’s main. There is a contributing guide for cudf here with more details: https://github.com/rapidsai/cudf/blob/branch-24.10/CONTRIBUTING.md#your-first-issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants