Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cufile to rapids-cpm #717

Open
vyasr opened this issue Nov 6, 2024 · 1 comment
Open

Add support for cufile to rapids-cpm #717

vyasr opened this issue Nov 6, 2024 · 1 comment
Assignees

Comments

@vyasr
Copy link
Contributor

vyasr commented Nov 6, 2024

We currently use cufile in both cudf and kvikio. They are each carrying around a custom find module for this, and cudf has a little extra logic as well to make sure things work. cudf was using the resulting targets correctly, but kvikio was (until rapidsai/kvikio#540) incorrectly adding include dirs and not using these targets. Especially now that kvikio is going to publish a library instead of being header-only, we would benefit from ensuring that we synchronize and maintain a clean find module for cufile that may be reused appropriately. I'd like to see that tool added to rapids-cmake.

@vyasr
Copy link
Contributor Author

vyasr commented Nov 6, 2024

Upon further inspection, the custom find modules aren't leveraging the built-in (since 3.25) CMake cufile support and are instead finding from scratch. If the built-in module works as-is then we may be able to use that directly and we can close this issue. If it has any problem we may need to carry around patches in rapids-cmake for a bit until we can get them upstreamed and update our required CMake version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants