Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit CMake for manually handling properties that should be handled by targets or rapids-cmake functions #541

Open
vyasr opened this issue Nov 6, 2024 · 0 comments
Assignees

Comments

@vyasr
Copy link
Contributor

vyasr commented Nov 6, 2024

#527 and associated work has demonstrated that kvikio's CMake is in need of some clean up. As a starting point, I would like to see

  • Use CMake's built-in cufile support if possible, and if necessary add a wrapper in rapids-cmake. Remove the custom find module from kvikio along with its export.
  • Use of rapids_cuda_set_runtime to handle linking to cuda targets.
  • Removal of direct setting of include directories (and perhaps other properties) that ought to be handled by target linking alone.
  • Usage of the ConfigureCUDA module, without which we're not actually setting the compiler flags that we might think.
  • Custom CMake settings like this (this one may actually make sense to upstream to rapids-cmake's cpm gtest module in some fashion since I imagine that almost all RAPIDS libraries would be happy with always dumping output on test failures).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants