Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce duplication, removed unused things in dependencies.yaml #2529

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

jameslamb
Copy link
Member

Proposes some small cleanup for dependencies.yaml

  • removes rapids_build_setuptools dependency group
  • breaks cuda-python and rmm out into depends_on_* groups to reduce duplication, and for consistency with other RAPIDS projects (docs explaining this)
  • alphabetizes lists

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 16, 2024
Copy link

copy-pr-bot bot commented Dec 16, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb
Copy link
Member Author

/ok to test

@jameslamb jameslamb changed the title WIP: reduce duplication, removed unused things in dependencies.yaml reduce duplication, removed unused things in dependencies.yaml Dec 16, 2024
@jameslamb jameslamb marked this pull request as ready for review December 16, 2024 17:55
@jameslamb jameslamb requested a review from a team as a code owner December 16, 2024 17:55
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've been meaning to clean some of this up for a while.

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit bfd1906 into rapidsai:branch-25.02 Dec 17, 2024
72 checks passed
@jameslamb jameslamb deleted the dependencies-cleanup branch December 17, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants