Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of the raft::device_resources_snmg type #2487

Open
wants to merge 11 commits into
base: branch-25.02
Choose a base branch
from

Conversation

viclafargue
Copy link
Contributor

@viclafargue viclafargue commented Nov 8, 2024

Introduces the raft::device_resources_snmg type to hold all resources required for the NCCL clique.

Answers #2459
Removed call to raft::comms::build_comms_nccl_only (#2465)

@viclafargue viclafargue requested a review from a team as a code owner November 8, 2024 17:16
@github-actions github-actions bot added the cpp label Nov 8, 2024
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (d7e68f5) to head (9780ca5).

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-25.02    #2487   +/-   ##
=============================================
  Coverage         81.16%   81.16%           
=============================================
  Files                19       19           
  Lines               515      515           
=============================================
  Hits                418      418           
  Misses               97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viclafargue viclafargue changed the title NCCL clique initialization function Introduction of the raft::device_resources_snmg type Nov 15, 2024
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took another look and I think the implementation itself is great. The only suggestions I have are related to the docs. I understand this is a lower-level detail for most users but we should strive to provide as much info and details as possible for both end-users AND for future implementors of SNMG algorithms.

@cjnolet cjnolet changed the base branch from branch-24.12 to branch-25.02 December 12, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants