-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction of the raft::device_resources_snmg
type
#2487
base: branch-25.02
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-25.02 #2487 +/- ##
=============================================
Coverage 81.16% 81.16%
=============================================
Files 19 19
Lines 515 515
=============================================
Hits 418 418
Misses 97 97 ☔ View full report in Codecov by Sentry. |
raft::device_resources_snmg
type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took another look and I think the implementation itself is great. The only suggestions I have are related to the docs. I understand this is a lower-level detail for most users but we should strive to provide as much info and details as possible for both end-users AND for future implementors of SNMG algorithms.
Introduces the
raft::device_resources_snmg
type to hold all resources required for the NCCL clique.Answers #2459Removed call to
raft::comms::build_comms_nccl_only
(#2465)