Revert "Revert "Build C++ wheel (#2264)"" #2306
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## branch-24.06 #2306 +/- ##
=============================================
Coverage 87.27% 87.27%
=============================================
Files 25 25
Lines 550 550
=============================================
Hits 480 480
Misses 70 70 ☔ View full report in Codecov by Sentry. |
jameslamb
reviewed
Jul 3, 2024
| # Iterate over the array | ||
| for wheelhouse in "${WHEELHOUSES[@]}"; do | ||
| FIND_LINKS+="--find-links ${wheelhouse} " | ||
| done |
There was a problem hiding this comment.
Whenever we pick this back up, I think it'd be preferable to switch away from FIND_LINKS towards a constraint file, as described in rapidsai/build-planning#69 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2305
Opening this preemptively for tracking, but no plans to try and merge this for a while (see rapidsai/build-planning#33 (comment)).