Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.9 support #102

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Aug 23, 2024

Description

Contributes to rapidsai/build-planning#88.

Drops Python 3.9 support.

Notes for Reviewers

Is this safe for nvmath-python?

I think yes.

In an offline conversation, I was told that nvmath-python follows NEP 29 (https://numpy.org/neps/nep-0029-deprecation_policy.html) and so would want to drop Python 3.9 in its next release anyway.

That's documented in its docs as well:

https://github.com/NVIDIA/nvmath-python/blob/7c485842d0f3300e03ec780056936503913910fe/docs/sphinx/overview.rst?plain=1#L274

cc @leofang

How I tested this

Checked that there were no remaining uses like this:

git grep -E '3\.9'
git grep '39'
git grep 'py39'

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

What are these other changes?

ruff raised two new errors here:

.ycm_extra_conf.py:24:5: N802 Function name `Settings` should be lowercase
pynvjitlink/patch.py:226:20: UP031 Use format specifiers instead of percent format
Found 2 errors.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).

Left Settings untouched... looks like ycm expects that to be exactly Settings (ycm-core docs).

The verify-copyright hook also complained about one file missing a copyright header

In file .ycm_extra_conf.py:1:1:
 import os
warning: no copyright notice found

So I added one.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 23, 2024
@jameslamb jameslamb requested review from a team as code owners August 23, 2024 19:20
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think Leo gets back next week. Let's wait for him to review

@jameslamb
Copy link
Member Author

Ah right. Ok no problem! This doesn't block the rest of RAPIDS, it can happen at any time.

@leofang
Copy link
Member

leofang commented Aug 26, 2024

Thanks, James!

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 1bda65d into rapidsai:main Aug 26, 2024
39 checks passed
@jameslamb jameslamb deleted the drop-python-3.9 branch August 26, 2024 14:33
@jakirkham jakirkham mentioned this pull request Oct 24, 2024
gmarkall pushed a commit that referenced this pull request Oct 25, 2024
* Fix building tests in multi-gpu environment (#98) 
* Change cmake.verbose = true to build.verbose = true (#99) 
* Use build-system.requires to set scikit-build-core minimum version
(#100)
* Set CUDA version in one file (and use everywhere else) (#101) 
* Drop Python 3.9 support (#102) 
* Use CI workflow branch 'branch-24.10' again (#105) 
* Use conda strict channel priority. (#109) 
* Update to CUDA 12.6 (#97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants