-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.9 support #102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
Improves an existing functionality
non-breaking
Introduces a non-breaking change
labels
Aug 23, 2024
11 tasks
bdice
approved these changes
Aug 23, 2024
jakirkham
previously requested changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think Leo gets back next week. Let's wait for him to review
Ah right. Ok no problem! This doesn't block the rest of RAPIDS, it can happen at any time. |
leofang
approved these changes
Aug 26, 2024
Thanks, James! |
jakirkham
approved these changes
Aug 26, 2024
/merge |
Merged
gmarkall
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Fix building tests in multi-gpu environment (#98) * Change cmake.verbose = true to build.verbose = true (#99) * Use build-system.requires to set scikit-build-core minimum version (#100) * Set CUDA version in one file (and use everywhere else) (#101) * Drop Python 3.9 support (#102) * Use CI workflow branch 'branch-24.10' again (#105) * Use conda strict channel priority. (#109) * Update to CUDA 12.6 (#97)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#88.
Drops Python 3.9 support.
Notes for Reviewers
Is this safe for
nvmath-python
?I think yes.
In an offline conversation, I was told that
nvmath-python
follows NEP 29 (https://numpy.org/neps/nep-0029-deprecation_policy.html) and so would want to drop Python 3.9 in its next release anyway.That's documented in its docs as well:
https://github.com/NVIDIA/nvmath-python/blob/7c485842d0f3300e03ec780056936503913910fe/docs/sphinx/overview.rst?plain=1#L274
cc @leofang
How I tested this
Checked that there were no remaining uses like this:
And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).
What are these other changes?
ruff
raised two new errors here:Left
Settings
untouched... looks likeycm
expects that to be exactlySettings
(ycm-core docs).The
verify-copyright
hook also complained about one file missing a copyright headerSo I added one.