Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve compatibility mode consistency #567

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Improve compatibility mode consistency #567

merged 4 commits into from
Dec 9, 2024

Conversation

kingcrimsontianyu
Copy link
Contributor

@kingcrimsontianyu kingcrimsontianyu commented Dec 4, 2024 •
edited
Loading

This PR adjusts the behavior of the file handle's compatibility mode to make it more consistent with its naming, i.e. AUTO actively falls back to the compatibility mode when any GDS step goes wrong; OFF sticks to the GDS path and errors out when things go wrong.

@kingcrimsontianyu kingcrimsontianyu changed the base branch from branch-24.12 to branch-25.02 December 4, 2024 20:29
@kingcrimsontianyu kingcrimsontianyu self-assigned this Dec 4, 2024
@kingcrimsontianyu kingcrimsontianyu added improvement Improves an existing functionality non-breaking Introduces a non-breaking change c++ Affects the C++ API of KvikIO labels Dec 4, 2024
madsbk
madsbk reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good with a test. Is it possible to make a file path in testing that cannot be opened with the O_DIRECT flag?

@kingcrimsontianyu
Copy link
Contributor Author

@madsbk Hmm. I'm not sure how to do that. OpenBSD does not support direct I/O, so open any file with this flag would fail, but I'm not sure how to cause the failure in a more generic, OS-agnostic way.
Imo, mock test (#556) is probably best suited for the compatibility mode-related test.

madsbk
madsbk approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 9, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@vuule vuule marked this pull request as ready for review December 9, 2024 17:34
@vuule vuule requested a review from a team as a code owner December 9, 2024 17:34
@kingcrimsontianyu
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d49ed59 into rapidsai:branch-25.02 Dec 9, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@madsbk madsbk madsbk approved these changes

Assignees

@kingcrimsontianyu kingcrimsontianyu

Labels
c++ Affects the C++ API of KvikIO improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kingcrimsontianyu @madsbk @vuule