Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exporting of include directories #540

Merged
merged 4 commits into from
Nov 6, 2024
+7 −3
Merged

Fix exporting of include directories #540

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae10843
Fix exporting of include directories
KyleFromNVIDIA Nov 6, 2024
b48a287
Style
KyleFromNVIDIA Nov 6, 2024
bcfaae0
Link against targets instead of using directories
KyleFromNVIDIA Nov 6, 2024
e78741e
Style
KyleFromNVIDIA Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,15 +125,15 @@ add_library(kvikio::kvikio ALIAS kvikio)

target_include_directories(
kvikio
PUBLIC "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>" "${CUDAToolkit_INCLUDE_DIRS}"
"${cuFile_INCLUDE_DIRS}"
PUBLIC "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>"
INTERFACE "$<INSTALL_INTERFACE:include>"
)

# Notice, we do not link to cuda or cufile since KvikIO opens them manually using `dlopen()`.
target_link_libraries(
kvikio
PUBLIC Threads::Threads BS::thread_pool ${CMAKE_DL_LIBS} $<TARGET_NAME_IF_EXISTS:nvtx3::nvtx3-cpp>
$<COMPILE_ONLY:$<TARGET_NAME_IF_EXISTS:CUDA::cudart>> $<COMPILE_ONLY:$<TARGET_NAME_IF_EXISTS:cufile::cufile>>
PRIVATE $<TARGET_NAME_IF_EXISTS:CURL::libcurl>
)

Expand Down
Loading