Quote packages so shells don't get unhappy #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
betatim
changed the title
bdice
reviewed
Nov 14, 2024
| if (pkg === "raft") return ["pylibraft" + cuda_suffix, "raft-dask" + cuda_suffix]; | ||
| if (pkg === "cuvs") return ["cuvs" + cuda_suffix, "pylibraft" + cuda_suffix]; | ||
| if (pkg === "cugraph/nx-cugraph") return ["cugraph" + cuda_suffix, "nx-cugraph" + cuda_suffix]; | ||
| return ["" + pkg + cuda_suffix]; |
There was a problem hiding this comment.
Is this empty string needed?
Suggested change
| return ["" + pkg + cuda_suffix]; | |
| return [pkg + cuda_suffix]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix #560
This moves the quoting to the end of
getpipCmdHtmland always applies it. Previously only the nightly version got quoted. but it required a leading"in each package name and a closing"in the CUDA suffix.I clicked through a few combinations of things for the
pipoption. As far as I can tell it works for all of them