Fix ucxx versioning #503
Merged
Fix ucxx versioning #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
AyodeAwe
force-pushed
the
fix-ucxx
branch
2 times, most recently
from
cbbc7fd
to
6096b60
Compare
pentschev
approved these changes
Mar 25, 2024
rapids-bot bot
pushed a commit
to rapidsai/ucxx
that referenced
this pull request
Mar 25, 2024
Further details [here](rapidsai/docs#503 (comment)). Authors: - Jake Awe (https://github.com/AyodeAwe) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #215
ajschmidt8
approved these changes
Mar 25, 2024
The directories should be renamed before this PR is merged. Otherwise the build on the default branch will not complete successfully since the old docs are still named incorrectly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the versioning discrepancy in the documentation of the
ucxxlibrary. Previously, we used the RAPIDS versioning convention forucxxin our docs workflow and overwrote the RAPIDS versioning withucxx's actual versioning during the deploy step. This PR updates the workflow to use the correctucxxversion number directly in our docs deployment workflow.Before this PR is merged, this PR should be merged - the PR updates the build step in
build_docs.shto use the correct version numbers when uploading docs to s3.Before both these PRs are merged, we should rename/re-sync the relevant directories up in
s3from the RAPIDS versioning used toucxx's.Testing:
Changes in
download_from_s3.shwere tested by running thedownload_lib_docsfunction locally. Other processing scripts were tested locally by downloadingrmmandlibucxx(legacy, stable, nightly) docs and runningci/post_process.sh. Outputs were as expected.