Skip to content

Commit

Permalink
add Python 3.12 support in install selector (#539)
Browse files Browse the repository at this point in the history
Co-authored-by: Bradley Dice <[email protected]>
  • Loading branch information
jameslamb and bdice authored Sep 18, 2024
1 parent a306aa3 commit c38238f
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 15 deletions.
29 changes: 15 additions & 14 deletions _includes/selector.html
Original file line number Diff line number Diff line change
Expand Up @@ -379,9 +379,9 @@
active_additional_packages: [],

// all possible values
python_vers: ["3.9", "3.10", "3.11"],
python_vers: ["3.9", "3.10", "3.11", "3.12"],
python_vers_stable: ["3.9", "3.10", "3.11"],
python_vers_nightly: ["3.10", "3.11"],
python_vers_nightly: ["3.10", "3.11", "3.12"],
conda_cuda_vers: ["11", "12"],
pip_cuda_vers: ["11.4 - 11.8", "12"],
docker_cuda_vers: ["11.8", "12.0", "12.5"],
Expand Down Expand Up @@ -664,8 +664,9 @@
getpipNotes() {
var notes = [];
var install_location_notes = "RAPIDS pip packages are hosted by NVIDIA<br>"
var version_string = this.getSupportedPythonVersions().map((v) => `<code>${v}</code>`).join(", ")
notes = [...notes, install_location_notes,
'pip installation supports Python <code>3.9</code>, <code>3.10</code>, and <code>3.11</code>.<br>'];
`pip installation supports the following Python versions: ${version_string}.<br>`];

return notes.map(note => this.note_prefix + " " + note);
},
Expand Down Expand Up @@ -695,6 +696,12 @@
return this.getpipCmdHtml();
return "Not implemented yet!";
},
getSupportedPythonVersions() {
if (this.active_release === "Stable") {
return this.python_vers_stable;
}
return this.python_vers_nightly;
},
disableUnsupportedRelease(release) {
var isDisabled = false;
if (this.active_img_loc === "NGC" && this.active_method === "Docker" && release === "Nightly") isDisabled = true;
Expand All @@ -706,12 +713,7 @@
return isDisabled;
},
disableUnsupportedPython(python_version) {
var isDisabled = false;
if (this.active_release === "Stable") {
isDisabled = !this.python_vers_stable.includes(python_version)
} else if (this.active_release === "Nightly") {
isDisabled = !this.python_vers_nightly.includes(python_version)
}
var isDisabled = !this.getSupportedPythonVersions().includes(python_version)
return isDisabled;
},
disableUnsupportedImgType(type) {
Expand Down Expand Up @@ -744,11 +746,10 @@
This handles that case, updating to the oldest Python version supported by the chosen release.
*/
if (this.active_release === "Stable" && !this.python_vers_stable.includes(this.active_python_ver)) {
this.active_python_ver = this.python_vers_stable[0];
} else if (this.active_release === "Nightly" && !this.python_vers_nightly.includes(this.active_python_ver)) {
this.active_python_ver = this.python_vers_nightly[0];
}
var supported_python_versions = this.getSupportedPythonVersions()
if (!supported_python_versions.includes(this.active_python_ver)) {
this.active_python_ver = supported_python_versions[supported_python_versions.length - 1];
}
},
imgTypeClickHandler(e, type) {
if (this.isDisabled(e.target)) return;
Expand Down
3 changes: 2 additions & 1 deletion install/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,9 @@ ERROR: Could not find a version that satisfies the requirement cudf-cu12 (from v
ERROR: No matching distribution found for cudf-cu12
```
Check the suggestions below for possible resolutions:

- The pip index has moved from the initial experimental release! Ensure the correct `--extra-index-url=https://pypi.nvidia.com`
- Only Python versions 3.10 and 3.11 are supported
- Ensure you're using a Python version that RAPIDS supports (compare the values in the [the install selector](#selector) to the Python version reported by `python --version`).
- RAPIDS pip packages require a recent version of pip that [supports PEP600](https://peps.python.org/pep-0600/){: target="_blank"}. Some users may need to update pip: `pip install -U pip`

<br/>
Expand Down

0 comments on commit c38238f

Please sign in to comment.