Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requre NumPy 1.23+ #1316

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Requre NumPy 1.23+ #1316

merged 2 commits into from
Feb 28, 2024

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Feb 28, 2024 •
edited
Loading

As NumPy 1.23 is needed for Python 3.11 support, go ahead and bump the minimum NumPy version used by Dask-CUDA to match that.

xref: #1315
xref: rapidsai/build-planning#3

@jakirkham
Bump NumPy to 1.23
068d232 
As NumPy 1.23 is needed for Python 3.11 support, go ahead and bump the
minimum NumPy version used by Dask-CUDA to match that.
@jakirkham jakirkham requested a review from a team as a code owner February 28, 2024 00:28
@github-actions github-actions bot added the conda conda issue label Feb 28, 2024
@jakirkham jakirkham mentioned this pull request Feb 28, 2024
Merged
@jakirkham jakirkham added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 28, 2024
@jakirkham jakirkham changed the title Bump NumPy to 1.23 Requre NumPy 1.23+ Feb 28, 2024
@jakirkham jakirkham mentioned this pull request Feb 28, 2024
Closed
8 tasks
madsbk
madsbk approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks John

pentschev
pentschev approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jakirkham
Copy link
Member Author

jakirkham commented Feb 28, 2024 •
edited
Loading

Depends on PR: rapidsai/ucxx#199

Edit: Currently the case as the Python 3.11 job fails without packages from UCXX

@jakirkham
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit eed39f4 into rapidsai:branch-24.04 Feb 28, 2024
28 checks passed
@jakirkham jakirkham deleted the req_numpy_123 branch February 28, 2024 22:57
@jakirkham
Copy link
Member Author

Thanks all! 🙏

younseojava pushed a commit to ROCm/dask-cuda-rocm that referenced this pull request Apr 16, 2024
@jakirkham @younseojava
Requre NumPy 1.23+ (rapidsai#1316)
bc0c9a5 
As NumPy 1.23 is needed for Python 3.11 support, go ahead and bump the minimum NumPy version used by Dask-CUDA to match that.

xref: rapidsai#1315
xref: rapidsai/build-planning#3

Authors:
  - https://github.com/jakirkham
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Mads R. B. Kristensen (https://github.com/madsbk)
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Jake Awe (https://github.com/AyodeAwe)

URL: rapidsai#1316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@pentschev pentschev pentschev approved these changes

@madsbk madsbk madsbk approved these changes

Assignees
No one assigned
Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakirkham @madsbk @pentschev @AyodeAwe @bdice