-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small reorganization and fixes for test_spill
#1255
Conversation
while True: | ||
try: | ||
await client.run( | ||
delayed_worker_assert, | ||
0, | ||
0, | ||
0, | ||
) | ||
except AssertionError: | ||
gc.collect() | ||
else: | ||
break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want a max number of tries?
while True: | |
try: | |
await client.run( | |
delayed_worker_assert, | |
0, | |
0, | |
0, | |
) | |
except AssertionError: | |
gc.collect() | |
else: | |
break | |
for _ in range(10): | |
try: | |
await client.run( | |
delayed_worker_assert, | |
0, | |
0, | |
0, | |
) | |
except AssertionError: | |
gc.collect() | |
else: | |
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about this, but then I decided in favor of a timeout, as per description: "thus invoke garbage collection after del until it memory is actually released or the test times out.".
I think timing out is overall more appropriate than an arbitrarily-defined count. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The timeout is defined by the gen_test
decorator, and that reminded me we can now set it back to the 30 seconds it was before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pentschev
Thanks @madsbk ! |
/merge |
Do a minor reorganization on how
client.run()
is invoked and the centralize functions to check host and disk chunks.The failures seem related to
del
not cleaning up objects in time, thus invoke garbage collection afterdel
until it memory is actually released or the test times out. Local tests seem that invoking garbage collection once or twice is enough to prevent the test from failing.