Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small reorganization and fixes for test_spill #1255

Merged
merged 5 commits into from
Oct 4, 2023

Conversation

pentschev
Copy link
Member

Do a minor reorganization on how client.run() is invoked and the centralize functions to check host and disk chunks.

The failures seem related to del not cleaning up objects in time, thus invoke garbage collection after del until it memory is actually released or the test times out. Local tests seem that invoking garbage collection once or twice is enough to prevent the test from failing.

@pentschev pentschev added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Oct 3, 2023
@pentschev pentschev requested a review from a team as a code owner October 3, 2023 16:40
@github-actions github-actions bot added the python python code needed label Oct 3, 2023
Comment on lines +312 to +323
while True:
try:
await client.run(
delayed_worker_assert,
0,
0,
0,
)
except AssertionError:
gc.collect()
else:
break
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want a max number of tries?

Suggested change
while True:
try:
await client.run(
delayed_worker_assert,
0,
0,
0,
)
except AssertionError:
gc.collect()
else:
break
for _ in range(10):
try:
await client.run(
delayed_worker_assert,
0,
0,
0,
)
except AssertionError:
gc.collect()
else:
return

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about this, but then I decided in favor of a timeout, as per description: "thus invoke garbage collection after del until it memory is actually released or the test times out.".

I think timing out is overall more appropriate than an arbitrarily-defined count. What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timeout is defined by the gen_test decorator, and that reminded me we can now set it back to the 30 seconds it was before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pentschev

@pentschev
Copy link
Member Author

Thanks @madsbk !

@pentschev
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit b6212ea into rapidsai:branch-23.12 Oct 4, 2023
26 checks passed
@pentschev pentschev deleted the test-spill-fixes branch October 4, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants