Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent path conflict in builds #583

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

AyodeAwe
Copy link
Contributor

@AyodeAwe AyodeAwe commented Mar 25, 2024

Contributes to rapidsai/build-planning#54

Ensures that conda builds will fail in the presence of multiple packages with identical paths

@AyodeAwe AyodeAwe requested a review from a team as a code owner March 25, 2024 19:38
@github-actions github-actions bot added the ci label Mar 25, 2024
@AjayThorve AjayThorve added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 1, 2024
@AyodeAwe AyodeAwe changed the base branch from branch-24.04 to branch-24.06 April 3, 2024 18:40
@jameslamb jameslamb changed the title Prevent path conflict in builds WIP: Prevent path conflict in builds Apr 22, 2024
@jameslamb jameslamb marked this pull request as draft April 22, 2024 23:12
@jameslamb
Copy link
Member

Converting this back to draft until the issues are fixed.

@jameslamb
Copy link
Member

Looking at the logs today, I realized this is not failing for any build-time reasons. It's just test failures 🤔

Like this:

FAILED cuxfilter/tests/charts/deckgl/test_deckgl.py::TestDeckGL::test_init[cux_df1] - TypeError: __init__() got an unexpected keyword argument 'as_index'

(build link)

I strongly suspect that isn't related to the changes on this PR, and that that'll block any PR into cuxfilter until it's resolved.

@rjzamora
Copy link
Member

It looks like cuxfilter has a few test failures related to the dask-expr migration in dask.dataframe. Most of the migration issues are being tracked in rapidsai/cudf#15027

I'll add a note about cuxfilter to that meta issue, and will investigate as soon as I can.

In the mean time, it should be fine to set the following environment variable in CI (before dask.dataframe is ever imported):

export DASK_DATAFRAME__QUERY_PLANNING=False

(This is what cugraph is currently doing).

@jameslamb
Copy link
Member

Thanks for the fixes in #593! Just merged them in here. If that fixes CI here I'll put this up for review.

@jameslamb jameslamb changed the title WIP: Prevent path conflict in builds Prevent path conflict in builds Apr 26, 2024
@jameslamb jameslamb marked this pull request as ready for review April 26, 2024 17:42
@jameslamb
Copy link
Member

Alright this looks good! @AjayThorve I think this could be merged. Let me know if you have any other questions or concerns about what it's trying to accomplish.

Copy link
Member

@AjayThorve AjayThorve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@AjayThorve
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit bf585e2 into rapidsai:branch-24.06 Apr 26, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants