-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent path conflict in builds #583
Conversation
Converting this back to draft until the issues are fixed. |
Looking at the logs today, I realized this is not failing for any build-time reasons. It's just test failures 🤔 Like this:
I strongly suspect that isn't related to the changes on this PR, and that that'll block any PR into |
It looks like cuxfilter has a few test failures related to the dask-expr migration in I'll add a note about In the mean time, it should be fine to set the following environment variable in CI (before
(This is what cugraph is currently doing). |
Thanks for the fixes in #593! Just merged them in here. If that fixes CI here I'll put this up for review. |
Alright this looks good! @AjayThorve I think this could be merged. Let me know if you have any other questions or concerns about what it's trying to accomplish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
/merge |
Contributes to rapidsai/build-planning#54
Ensures that conda builds will fail in the presence of multiple packages with identical paths