Skip to content

Commit

Permalink
Run NumPy 2 ruff fixes (changing NaN to nan) (#606)
Browse files Browse the repository at this point in the history
This just fixes a simple error that would appear when run with NumPy 2 based on the ruff check.
(This does not mean there are no other issues.)

xref: rapidsai/build-planning#38

Authors:
  - Sebastian Berg (https://github.com/seberg)

Approvers:
  - Ajay Thorve (https://github.com/AjayThorve)

URL: #606
  • Loading branch information
seberg authored Jul 10, 2024
1 parent c6f46a5 commit 14237a1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions python/cuxfilter/tests/assets/test_gpu_histogram.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,12 @@ def test_calc_groupby(aggregate_fn, result):
@pytest.mark.parametrize(
"x, y, aggregate_fn, result",
[
("key", "val", "mean", np.array([[1.0, 2.0], [np.NaN, 3.0]])),
("key", "val", "mean", np.array([[1.0, 2.0], [np.nan, 3.0]])),
("val", "key", "mean", np.array([[3.0], [2.0]])),
],
)
def test_calc_groupby_for_nulls(x, y, aggregate_fn, result):
df = cudf.DataFrame({"key": [1, 2], "val": [np.NaN, 3]})
df = cudf.DataFrame({"key": [1, 2], "val": [np.nan, 3]})
bc = BaseChart()
bc.x = x
bc.y = y
Expand Down

0 comments on commit 14237a1

Please sign in to comment.