remove versioneer and setup.cfg references in docs, update rapids-dependency-file-generator #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endency-file-generator
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
jameslamb
changed the title
bdice
reviewed
Dec 24, 2024
| @@ -72,16 +72,12 @@ Specifically, cuSpatial uses the following tools: | |||
| - [`isort`](https://pycqa.github.io/isort/) ensures imports are sorted consistently. | |||
|
|
|||
| Linter config data is stored in a number of files. cuSpatial generally uses `pyproject.toml` over | |||
| `setup.cfg` and avoids project-specific files (e.g. `setup.cfg` > `python/cudf/setup.cfg`). However, | |||
| differences between tools and the different packages in the repo result in the following caveats: | |||
| `setup.cfg` and prefers root-level files to project-specific files. | |||
There was a problem hiding this comment.
I would be fine with removing the reference to setup.cfg altogether.
Also we need to do a pass through RAPIDS repos and get rid of flake8/black/isort in favor of ruff. There is no technical reason why we are still using flake8, we just haven't switched over to ruff in several RAPIDS repos. (The only minor caveat I am aware of is that isort supports Cython files while ruff's isort does not, but we decided not to worry about that.)
bdice
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes references to
setup.cfgandversioneerin the contributing docs...cuspatialno longer uses either of these.Also updates
rapids-dependency-file-generatorto its latest version (v1.17.0) and removes an unused YAML anchor independencies.yaml.Checklist