Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RMM get_current_device_resource_ref() #1454

Open
wants to merge 4 commits into
base: branch-24.10
Choose a base branch
from

Conversation

harrism
Copy link
Member

@harrism harrism commented Sep 5, 2024

Description

merge after rapidsai/rmm#1661

This PR updates cuspatial to use rmm::mr::get_current_device_resource_ref() to accomodate upcoming changes in RMM.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Sep 5, 2024
@harrism harrism added feature request New feature or request breaking Breaking change and removed libcuspatial Relates to the cuSpatial C++ library labels Sep 5, 2024
@harrism harrism marked this pull request as ready for review September 5, 2024 04:35
@harrism harrism requested a review from a team as a code owner September 5, 2024 04:35
@harrism harrism requested review from trxcllnt and isVoid September 5, 2024 04:35
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Sep 5, 2024
@harrism harrism self-assigned this Sep 5, 2024
@jameslamb
Copy link
Member

The failure in the conda devcontainer build definitely looks related to the changes I made in #1450.

      File "/home/coder/cuspatial/python/libcuspatial/libcuspatial/__init__.py", line 16, in <module>
  
        from libcuspatial.load import load_library
  
      File "/home/coder/cuspatial/python/libcuspatial/libcuspatial/load.py", line 19, in <module>
  
        import libcudf
  
    ModuleNotFoundError: No module named 'libcudf'
  
    error: subprocess-exited-with-error
    
    × Building editable for cuproj-cu12 (pyproject.toml) did not run successfully.
    │ exit code: 1
    ╰─> See above for output.
    
    note: This error originates from a subprocess, and is likely not a problem with pip.
  
    full command: /home/coder/.conda/envs/rapids/bin/python /home/coder/.conda/envs/rapids/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py build_editable /tmp/tmp3owulgd3
    cwd: /home/coder/cuspatial/python/cuproj
    Building editable for cuproj-cu12 (pyproject.toml): finished with status 'error'
  
    ERROR: Failed building editable for cuproj-cu12
  
  Failed to build cuproj-cu12

(build link)

I'll investigate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change feature request New feature or request libcuspatial Relates to the cuSpatial C++ library
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

2 participants