-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace cudf column.full with cudf.as_column #1350
Conversation
@mroeschke looks like there is one real error caused by RangeIndexes looking different |
#1349 is now failing because of the failed import of |
@mroeschke FYI, this PR is also blocking cuxfilter CI. |
One legitimate failure is copied below (to separate from the noise of unrelated CI failures):
|
Following change: #1350 (comment) will fix the CI failure. |
Co-authored-by: GALI PREM SAGAR <[email protected]>
Co-authored-by: GALI PREM SAGAR <[email protected]>
I'll pre-emptively trigger a merge on this since we expect things to pass and it's blocking other work. |
/merge |
Co-authored-by: Lawrence Mitchell <[email protected]>
Looks like this PR is green except for the timed-out falures (I don't have permission to re-run those jobs) |
I reran the failed jobs. |
Description
I have a PR in cudf removing
full
in favor ofas_column
which has equivalent functionality (rapidsai/cudf#14698), so replacing the single usage I found hereChecklist