Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cudf column.full with cudf.as_column #1350

Merged
merged 7 commits into from
Mar 5, 2024

Conversation

mroeschke
Copy link
Contributor

Description

I have a PR in cudf removing full in favor of as_column which has equivalent functionality (rapidsai/cudf#14698), so replacing the single usage I found here

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke requested a review from a team as a code owner February 28, 2024 00:37
@github-actions github-actions bot added the Python Related to Python code label Feb 28, 2024
@vyasr
Copy link
Contributor

vyasr commented Feb 28, 2024

@harrism harrism added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 28, 2024
@harrism
Copy link
Member

harrism commented Mar 5, 2024

#1349 is now failing because of the failed import of full. I would like to get this merged. @mroeschke what is the blocker?

@bdice
Copy link
Contributor

bdice commented Mar 5, 2024

@mroeschke FYI, this PR is also blocking cuxfilter CI.

@bdice
Copy link
Contributor

bdice commented Mar 5, 2024

One legitimate failure is copied below (to separate from the noise of unrelated CI failures):
https://github.com/rapidsai/cuspatial/actions/runs/8086937898/job/22098408527?pr=1350#step:7:17280

=========================== short test summary info ============================
FAILED tests/spatial/distance/test_distance.py::test_geoseries_distance_indices_different - AssertionError: ColumnBase are different

values are different (100.0 %)
[left]:  {'[0.0, <NA>]'}
[right]: {'[0.0, nan]'}

@galipremsagar
Copy link
Contributor

One legitimate failure is copied below (to separate from the noise of unrelated CI failures): https://github.com/rapidsai/cuspatial/actions/runs/8086937898/job/22098408527?pr=1350#step:7:17280

=========================== short test summary info ============================
FAILED tests/spatial/distance/test_distance.py::test_geoseries_distance_indices_different - AssertionError: ColumnBase are different

values are different (100.0 %)
[left]:  {'[0.0, <NA>]'}
[right]: {'[0.0, nan]'}

Following change: #1350 (comment) will fix the CI failure.

@bdice
Copy link
Contributor

bdice commented Mar 5, 2024

I'll pre-emptively trigger a merge on this since we expect things to pass and it's blocking other work.

@bdice
Copy link
Contributor

bdice commented Mar 5, 2024

/merge

@mroeschke
Copy link
Contributor Author

Looks like this PR is green except for the timed-out falures (I don't have permission to re-run those jobs)

@bdice
Copy link
Contributor

bdice commented Mar 5, 2024

I reran the failed jobs.

@rapids-bot rapids-bot bot merged commit f29e404 into rapidsai:branch-24.04 Mar 5, 2024
72 checks passed
@mroeschke mroeschke deleted the ref/full branch March 5, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

6 participants