Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify copyright headers are up to date #1328

Closed
wants to merge 2 commits into from
Closed

Verify copyright headers are up to date #1328

wants to merge 2 commits into from

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 23, 2024 •
edited
Loading

Description

This PR adds a pre-commit hook to verify that copyright headers are up to date.

Closes #995.

For now, I am using this draft PR to test rapidsai/pre-commit-hooks#9.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jan 23, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added conda Related to conda and conda configuration cmake Related to CMake code or build configuration Python Related to Python code libcuspatial Relates to the cuSpatial C++ library ci labels Jan 23, 2024
@bdice bdice mentioned this pull request Jan 23, 2024
Merged
@bdice bdice changed the base branch from branch-24.02 to branch-24.04 January 23, 2024 01:11
@github-actions github-actions bot removed conda Related to conda and conda configuration Python Related to Python code libcuspatial Relates to the cuSpatial C++ library ci labels Jan 24, 2024
@bdice
Copy link
Contributor Author

bdice commented Mar 4, 2024

Closing in favor of #1349, which adds the verify-copyright pre-commit hook.

@bdice bdice closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

Assignees
No one assigned
Labels
5 - DO NOT MERGE Hold off on merging; see PR for details cmake Related to CMake code or build configuration
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Auto Detect Copyright Change in Pre-commit
2 participants
@bdice @harrism