Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip-ci] Experimental work with Binary Operation Dispatcher (Python) #1075

Closed
wants to merge 66 commits into from
Closed

[skip-ci] Experimental work with Binary Operation Dispatcher (Python) #1075

wants to merge 66 commits into from

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Apr 14, 2023

Description

Last puzzle piece for st_distance. Currently experimental.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

isVoid added 30 commits March 23, 2023 18:12
@isVoid
initial
7022c1d
@isVoid
add segment iterator and tests
5686be3
@isVoid
WIP
a74af14
@isVoid
making progress towards getting the right index
1c28faa
@isVoid
commiting progress
243d2d9
@isVoid
able to get the right segment combinations from within the kernel, ne…
0da0afc 
…ed to test more rigidly
@isVoid
[skip-ci] initial port from feature/linestring_polygon_distance_header
49e43aa
@isVoid
Apply suggestions from code review
e8e45d0
@isVoid
Update cpp/include/cuspatial/experimental/detail/functors.cuh
fadf5c8
@isVoid
address review comments
fe31542
@isVoid
address review comments
af0c35e
@isVoid
[skip-ci] address review coments
05bf7ff
@isVoid
Add docstrings for functors
2435126
@isVoid
[skip-ci] adds linestring_count test
98a4a0f
@isVoid
[skip-ci] revert removed code
9b72723
@isVoid
style
6971200
@isVoid
update unexpected changes
6f7a226
@isVoid
license
641934f
@isVoid
Merge branch 'feature/segment_iterators' into feature/linestring_poly…
c580876 
…gon_distance_header
@isVoid
Update cpp/include/cuspatial/experimental/detail/ranges/multilinestri…
890e95b 
…ng_range.cuh
@isVoid
making a bit of progress
040e432
@isVoid
fix broken multilinestring->multipoint constructor
7c3603c
@isVoid
Merge branch 'feature/segment_iterators' of github.com:isVoid/cuspati…
5966ad0 
…al into feature/segment_iterators
@isVoid
fix broken multilinestring->multipoint constructor
70ca1b6
@isVoid
passing existing tests
9205533
@isVoid
fix wrong test setup and update docs
4bb3ca3
@isVoid
Merge branch 'feature/segment_iterators' into feature/linestring_poly…
9f34700 
…gon_distance_header
@isVoid
style
8f20feb
@isVoid
Delete point_in_multipolygon.cuh
3ffe5ee
@isVoid
Delete linestring_polygon_distance.hpp
894f870
isVoid added 21 commits April 10, 2023 09:22
@isVoid
Merge branch 'feature/linestring_polygon_distance_column' into featur…
e6fdd67 
…e/linestring_polygon_distance_python
@isVoid
Merge branch 'branch-23.06' into feature/linestring_polygon_distance_…
d4063d2 
…python
@isVoid
initial
0792c4e
@isVoid
add range cast methods
1f7c674
@isVoid
passing range cast tests
c92656c
@isVoid
passing one-pair, no-hole simple polygon tests
7092c3b
@isVoid
Merge branch 'branch-23.06' of https://github.com/rapidsai/cuspatial …
211dca8 
…into feature/polygon_distance_header
@isVoid
add polygon test
b74d180
@isVoid
adds single pair test that has holes in polygons
0b77e38
@isVoid
fix with_param fixture doc, add multipolygon test
002ffa0
@isVoid
add two pair tests
137a567
@isVoid
style
b77285c
@isVoid
address review comments
9224c4a
@isVoid
Merge branch 'branch-23.06' into feature/linestring_polygon_distance_…
d09edd0 
…python
@isVoid
add column API and tests, create host-device expect function
cc66aeb
@isVoid
initial addition of python test and API
b77718b
@isVoid
style
4ad93b1
@isVoid
Merge branch 'feature/linestring_polygon_distance_python' of github.c…
a6ab4d3 
…om:isVoid/cuspatial into feature/linestring_polygon_distance_python
@isVoid
code change and use better style
b17d7e8
@isVoid
Merge branch 'feature/polygon_distance_python' into feature/st_distan…
9797b8f 
…ce_python_impl
@isVoid
[skip-ci] initial
3d65049
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library Python Related to Python code labels Apr 14, 2023
@isVoid isVoid self-assigned this Apr 14, 2023
@ajschmidt8
Copy link
Member

@isVoid, just an FYI. adding [skip-ci] to the PR title doesn't do anything for GitHub Actions.

please review the page below to figure out how to skip CI for GitHub Actions.

@isVoid
Copy link
Contributor Author

isVoid commented Apr 26, 2023

Roger that!

@isVoid
Copy link
Contributor Author

isVoid commented Apr 26, 2023

We've decided to implemented mixed-geometry column in c++ #1057 . And thus the dispatching mechanism is best implemented in C++ as well. Closing.

@isVoid isVoid closed this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@isVoid isVoid

Labels
cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library Python Related to Python code
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isVoid @ajschmidt8