Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put a ceiling on cuda-python #6131

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 6, 2024

This project is incompatible with newer versions of cuda-python. This puts ceilings of <=11.8.3 (CUDA 11) and <=12.6.0 (CUDA 12) on that library.

Those ceilings should be removed and replaced with != constraints once new releases of cuda-python are up that this project is compatible with.

See rapidsai/build-planning#116 for more information.

@bdice bdice requested a review from a team as a code owner November 6, 2024 12:38
@bdice bdice requested a review from AyodeAwe November 6, 2024 12:38
@bdice bdice added non-breaking Non-breaking change bug Something isn't working labels Nov 6, 2024
@github-actions github-actions bot added the conda conda issue label Nov 6, 2024
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Nov 6, 2024
@jameslamb jameslamb requested review from jameslamb and removed request for AyodeAwe November 6, 2024 21:57
@jameslamb
Copy link
Member

jameslamb commented Nov 7, 2024

Wheel tests here are failing like this:

E ImportError: /pyenv/versions/3.10.15/lib/python3.10/site-packages/pylibcudf/expressions.cpython-310-x86_64-linux-gnu.so: undefined symbol: _ZN4cudf6detail18fixed_width_scalarIN4cuda3std3__46chrono10time_pointINS5_12system_clockENS5_8durationIlNS4_5ratioILl1ELl1000EEEEEEEE4dataEv

full stack trace (click me)
For more information see https://pluggy.readthedocs.io/en/stable/api_reference.html#pluggy.PluggyTeardownRaisedWarning
  config = pluginmanager.hook.pytest_cmdline_parse(
ImportError while loading conftest '/__w/cuml/cuml/python/cuml/cuml/tests/conftest.py'.
conftest.py:17: in <module>
    from cuml.testing.utils import create_synthetic_dataset
/pyenv/versions/3.10.15/lib/python3.10/site-packages/cuml/__init__.py:17: in <module>
    from cuml.internals.base import Base, UniversalBase
/pyenv/versions/3.10.15/lib/python3.10/site-packages/cuml/internals/__init__.py:18: in <module>
    from cuml.internals.base_helpers import BaseMetaClass, _tags_class_and_instance
/pyenv/versions/3.10.15/lib/python3.10/site-packages/cuml/internals/base_helpers.py:20: in <module>
    from cuml.internals.api_decorators import (
/pyenv/versions/3.10.15/lib/python3.10/site-packages/cuml/internals/api_decorators.py:24: in <module>
    from cuml.internals import input_utils as iu
/pyenv/versions/3.10.15/lib/python3.10/site-packages/cuml/internals/input_utils.py:20: in <module>
    from cuml.internals.array import CumlArray
/pyenv/versions/3.10.15/lib/python3.10/site-packages/cuml/internals/array.py:21: in <module>
    from cuml.internals.global_settings import GlobalSettings
/pyenv/versions/3.10.15/lib/python3.10/site-packages/cuml/internals/global_settings.py:20: in <module>
    from cuml.internals.device_type import DeviceType
/pyenv/versions/3.10.15/lib/python3.10/site-packages/cuml/internals/device_type.py:19: in <module>
    from cuml.internals.mem_type import MemoryType
/pyenv/versions/3.10.15/lib/python3.10/site-packages/cuml/internals/mem_type.py:22: in <module>
    cudf = gpu_only_import("cudf")
/pyenv/versions/3.10.15/lib/python3.10/site-packages/cuml/internals/safe_imports.py:362: in gpu_only_import
    return importlib.import_module(module)
/pyenv/versions/3.10.15/lib/python3.10/site-packages/cudf/__init__.py:19: in <module>
    _setup_numba()
/pyenv/versions/3.10.15/lib/python3.10/site-packages/cudf/utils/_numba.py:121: in _setup_numba
    shim_ptx_cuda_version = _get_cuda_build_version()
/pyenv/versions/3.10.15/lib/python3.10/site-packages/cudf/utils/_numba.py:16: in _get_cuda_build_version
    from cudf._lib import strings_udf
/pyenv/versions/3.10.15/lib/python3.10/site-packages/cudf/_lib/__init__.py:4: in <module>
    from . import (
avro.pyx:1: in init cudf._lib.avro
    ???
utils.pyx:1: in init cudf._lib.utils
    ???
column.pyx:1: in init cudf._lib.column
    ???
scalar.pyx:1: in init cudf._lib.scalar
    ???
/pyenv/versions/3.10.15/lib/python3.10/site-packages/pylibcudf/__init__.py:13: in <module>
    from . import (
E   ImportError: /pyenv/versions/3.10.15/lib/python3.10/site-packages/pylibcudf/expressions.cpython-310-x86_64-linux-gnu.so: undefined symbol: _ZN4cudf6detail18fixed_width_scalarIN4cuda3std3__46chrono10time_pointINS5_12system_clockENS5_8durationIlNS4_5ratioILl1ELl1000EEEEEEEE4dataEv

(build link)

I suspect there was some recent change in cudf? Maybe it's notable that conda-python-tests jobs are passing and getting pylibcudf==24.12.00a297, while wheel-tests-cuml jobs are failing (running the same test code) and getting pylibcudf==24.12.00a295.

@jameslamb jameslamb changed the title Disallow cuda-python 12.6.1 and 11.8.4 Put a ceiling on cuda-python Nov 7, 2024
@jameslamb
Copy link
Member

I just restarted all CI here. That cudf issue should be fixed now that there are new cudf nightly packages.

@jameslamb
Copy link
Member

/merge

1 similar comment
@divyegala
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 9150279 into rapidsai:branch-24.12 Nov 7, 2024
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conda conda issue Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants