Fix check_labels function
#5971
Open
+65
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
divyegala
reviewed
Jul 30, 2024
|
|
||
| __syncthreads(); | ||
|
|
||
| if (!found && tid < n_labels) { |
There was a problem hiding this comment.
found will always be false at this point?
There was a problem hiding this comment.
A thread with tid < n_labels does not check the presence of a class for a label, but it is still necessary to correctly fetch the data for every pass. The found value will indeed always be false, but a thread with tid < n_labels will never write the final output, it should thus be safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #4923