Delete the deprecated data_type_id_t enum #4737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
improvement
seunghwak
reviewed
Oct 24, 2024
|
|
||
| typedef enum data_type_id_ { | ||
| INT32 = 0, | ||
| INT64, |
There was a problem hiding this comment.
No need to add INT8, INT16, UINT8, UINT16, UINT32, UINT64?
These may become necessary in some algorithms in the future.
There was a problem hiding this comment.
If we add these types but don't explicitly instantiate for these types, the cost is pretty minimal, right?
There was a problem hiding this comment.
We can keep the cost minimal. I have added them in the next push.
seunghwak
approved these changes
Oct 24, 2024
rlratzel
approved these changes
Oct 25, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep work for temporal graphs. We renamed
data_type_id_ttocugraph_data_id_tabout 8 months ago, this finishes the transition. We also split the types out into their own file in the C API.Marked as breaking since we are deleting a deprecated type from the C API.