Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print sccache stats in builds #4719

Merged
merged 17 commits into from
Oct 30, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Oct 14, 2024

Description

Contributes to rapidsai/build-planning#111

Proposes some small packaging/CI changes, matching similar changes being made across RAPIDS.

  • printing sccache stats to CI logs
  • updating to the latest rapids-dependency-file-generator (v1.16.0)
  • always explicitly specifying cpp / python in calls to rapids-upload-wheels-to-s3

Notes for Reviewers

This originally also ran wheel builds with --no-build-isolation, but I reverted that based on rapidsai/build-planning#108 (comment).

@jameslamb jameslamb added the improvement Improvement / enhancement to an existing function label Oct 14, 2024
@jameslamb jameslamb self-assigned this Oct 14, 2024
@jameslamb jameslamb added DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels Oct 14, 2024
@github-actions github-actions bot removed the python label Oct 23, 2024
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] build wheels without build isolation WIP: [DO NOT MERGE] printe sccache stats in builds Oct 29, 2024
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] printe sccache stats in builds WIP: [DO NOT MERGE] print sccache stats in builds Oct 29, 2024
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] print sccache stats in builds print sccache stats in builds Oct 29, 2024
@jameslamb jameslamb removed the DO NOT MERGE Hold off on merging; see PR for details label Oct 29, 2024
@jameslamb jameslamb marked this pull request as ready for review October 29, 2024 19:06
@jameslamb jameslamb requested a review from a team as a code owner October 29, 2024 19:06
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 050d524 into rapidsai:branch-24.12 Oct 30, 2024
132 checks passed
@jameslamb jameslamb deleted the wheel-build-no-isolation branch October 31, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants