Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated C API functions for graph creation/graph free #4718

Merged

Conversation

ChuckHastings
Copy link
Collaborator

Prep work for temporal, cleaning up some old functions that we deprecated a while back.

@ChuckHastings ChuckHastings requested review from a team as code owners October 14, 2024 18:31
@ChuckHastings ChuckHastings self-assigned this Oct 14, 2024
@ChuckHastings ChuckHastings added this to the 24.12 milestone Oct 14, 2024
@ChuckHastings ChuckHastings added improvement Improvement / enhancement to an existing function breaking Breaking change labels Oct 14, 2024
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cython changes LGTM. If CI passes, then I'll assume these removals are safe, since I'm not aware of anyone else using those functions.

@ChuckHastings
Copy link
Collaborator Author

/merge

@rapids-bot rapids-bot bot merged commit 0d0d28a into rapidsai:branch-24.12 Oct 16, 2024
132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change cuGraph improvement Improvement / enhancement to an existing function python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants