Tweak rmm configuration for C++ unit tests #4503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
improvement
seunghwak
reviewed
Jun 25, 2024
| { | ||
| // Reduce the default pool allocation to 1/6th of the GPU memory so that we can | ||
| // run more than 2 tests in parallel at the same time. Changes to this value could | ||
| // effect the maximum amount of parallel tests, and therefore `tests/CMakeLists.txt` | ||
| // `_CUGRAPH_TEST_PERCENT` default value will need to be audited. | ||
| auto const [free, total] = rmm::available_device_memory(); | ||
| auto const min_alloc = rmm::align_down(std::min(free, total / 6), rmm::CUDA_ALLOCATION_ALIGNMENT); |
There was a problem hiding this comment.
We should update the comments above (or delete it). It is out-of-sync now.
There was a problem hiding this comment.
Yes, I'll update.
seunghwak
approved these changes
Jun 26, 2024
jameslamb
approved these changes
Jun 27, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing intermittent failures in CI from having trouble allocating the RMM pool allocator.
Dropping the memory usage by default from 1/6 to 1/10.
Added an option
maxpoolthat will use 1/2 of the available memory, since we use the unit tests in larger configurations to do scale testing of algorithms.