Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c_api and plc binding for lookup src dst using edge ids and type(s) #4494

Merged
merged 33 commits into from
Jul 3, 2024
Merged

c_api and plc binding for lookup src dst using edge ids and type(s) #4494

merged 33 commits into from
Jul 3, 2024

Conversation

naimnv
Copy link
Contributor

@naimnv naimnv commented Jun 19, 2024 •
edited by ChuckHastings
Loading

c_api and plc binding for lookup src dst using edge ids and type(s)

Closes #4481

Naim and others added 25 commits May 29, 2024 01:51
Lookup edge src dst using edge id and type
88add92
fix linting
b1f494e
clang-format
bc14f96
Add FIXME
28f4805
Add missing semicolon
434c760
Restructure the files to conform to other algorithm implementation
e819797
Merge branch 'branch-24.06' of https://github.com/rapidsai/cugraph in…
bd093d2 
…to lookup_src_dst_using_edge_id_type
Remove unused function
367e2a5
Remove unused file
e36a5a8
Rearrange functions in a file
222a1e2
Check if value_t is thrust tuple of integral
e407ac6
Address PR comments
61f98d6
Address PR comments
0e80b4b
Merge branch 'branch-24.06' of https://github.com/rapidsai/cugraph in…
b05cc89 
…to lookup_src_dst_using_edge_id_type
Address additional PR comments
af1cb81
Address aditional PR comments
be642c9
Add vertex_t as template param and value_t as optional template param
60af60a
Address aditional PR comments
2db671e
Uncomment tests
2125800
Address PR comments
27c3646
Rename compute_gpu_id_from_ext_edge_t to compute_gpu_id_from_ext_edge…
a95e772 
…_id_t
Use compute_number_of_edges_with_mask instead of count_set_bits
b9745fe
@naimnv
Merge branch 'branch-24.08' into lookup_src_dst_using_edge_id_type
35b5c30
@naimnv
Merge branch 'branch-24.08' into lookup_src_dst_using_edge_id_type
9bd9b40
c_api and plc binding for lookup src dst using edge ids and type(s)
7b62110
@naimnv naimnv requested review from a team as code owners June 19, 2024 23:56
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 19, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@naimnv naimnv marked this pull request as draft June 19, 2024 23:56
@naimnv naimnv marked this pull request as ready for review June 30, 2024 23:50
@naimnv naimnv self-assigned this Jun 30, 2024
@naimnv naimnv added feature request New feature or request non-breaking Non-breaking change labels Jun 30, 2024
@naimnv
Copy link
Contributor Author

naimnv commented Jun 30, 2024

/okay to test

@naimnv naimnv added this to the 24.08 milestone Jun 30, 2024
@naimnv naimnv linked an issue Jun 30, 2024 that may be closed by this pull request
Implement PLC/C/C++ lookup src/dst vertex from edge id #4307
Closed
ChuckHastings
ChuckHastings reviewed Jul 1, 2024
View reviewed changes
cpp/src/c_api/lookup_src_dst.cpp Outdated Show resolved Hide resolved
cpp/src/c_api/lookup_src_dst.cpp Outdated Show resolved Hide resolved
cpp/src/c_api/lookup_src_dst.cpp Show resolved Hide resolved
cpp/src/c_api/lookup_src_dst.cpp Show resolved Hide resolved
cpp/src/c_api/lookup_src_dst.cpp Outdated Show resolved Hide resolved
cpp/src/c_api/lookup_src_dst.cpp Outdated Show resolved Hide resolved
cpp/tests/c_api/mg_lookup_src_dst_test.c Outdated Show resolved Hide resolved
cpp/src/c_api/lookup_src_dst.cpp Show resolved Hide resolved
cpp/src/c_api/lookup_src_dst.cpp Show resolved Hide resolved
@alexbarghi-nv alexbarghi-nv self-assigned this Jul 2, 2024
@alexbarghi-nv
Copy link
Member

I'm going to take over this PR since Naim is on leave

@alexbarghi-nv
Copy link
Member

Never mind, Naim is able to finish this PR. Sorry for the confusion.

@naimnv
Copy link
Contributor Author

naimnv commented Jul 2, 2024

/okay to test

@alexbarghi-nv alexbarghi-nv removed their assignment Jul 2, 2024
alexbarghi-nv
alexbarghi-nv approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexbarghi-nv
Copy link
Member

Looks like this PR is seeing the OOM error too

@naimnv
Copy link
Contributor Author

naimnv commented Jul 2, 2024 •
edited
Loading

Looks like this PR is seeing the OOM error too

We have been seeing this error occasionally, with different tests. I will rerun the failed jobs once the current run finishes.

@naimnv
Copy link
Contributor Author

naimnv commented Jul 3, 2024

/merge

@rapids-bot rapids-bot bot merged commit 2b1f452 into rapidsai:branch-24.08 Jul 3, 2024
132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarghi-nv alexbarghi-nv alexbarghi-nv approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

Assignees

@naimnv naimnv

Labels
CMake cuGraph feature request New feature or request non-breaking Non-breaking change python
Projects
None yet
Milestone
24.08
Development

Successfully merging this pull request may close these issues.

Add PLC/C API for lookup src/dst vertex from edge id Implement PLC/C/C++ lookup src/dst vertex from edge id
3 participants
@naimnv @alexbarghi-nv @ChuckHastings