Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken cpp_build by Pinning Openmpi Build Ver (24.08) #4473

Closed
wants to merge 3 commits into from

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented Jun 7, 2024

Addresses #4474

Currently openmpi=5.0.3-hfd7b305_105 is blocking our CI cpp_build job. This PR pins that version to unblock that.

Most likely introduced by this PR: conda-forge/openmpi-feedstock#158

@nv-rliu nv-rliu requested a review from a team as a code owner June 7, 2024 16:47
@nv-rliu nv-rliu requested a review from bdice June 7, 2024 16:48
@github-actions github-actions bot added the conda label Jun 7, 2024
@nv-rliu nv-rliu requested a review from rlratzel June 7, 2024 16:48
@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 7, 2024
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please link the issue to remove the temporary pinning to this PR when you get a chance.

@alexbarghi-nv
Copy link
Member

This needs to target 24.06 too. Builds for 24.06 are currently blocked which is delaying the release.

@nv-rliu nv-rliu changed the base branch from branch-24.08 to branch-24.06 June 7, 2024 18:29
@nv-rliu nv-rliu requested review from a team as code owners June 7, 2024 18:29
@nv-rliu nv-rliu changed the base branch from branch-24.06 to branch-24.08 June 7, 2024 18:29
@nv-rliu nv-rliu changed the title Fix Broken cpp_build by Pinning Openmpi Build Ver Fix Broken cpp_build by Pinning Openmpi Build Ver (24.08) Jun 7, 2024
@nv-rliu nv-rliu requested a review from a team as a code owner June 12, 2024 16:44
@jameslamb
Copy link
Member

@nv-rliu I think this PR can be closed, as all these changes ended up in 24.06 and then forward-merged into 24.08 in #4489.

You can see the pin made it to branch-24.08 here:

- openmpi<5.0.3 # Required for building cpp-mgtests (multi-GPU tests)

I've opened #4496 to test removing that pin.

@nv-rliu
Copy link
Contributor Author

nv-rliu commented Jun 24, 2024

@nv-rliu I think this PR can be closed, as all these changes ended up in 24.06 and then forward-merged into 24.08 in #4489.

You can see the pin made it to branch-24.08 here:

- openmpi<5.0.3 # Required for building cpp-mgtests (multi-GPU tests)

I've opened #4496 to test removing that pin.

Ah, thanks for the reminder @jameslamb

This was opened when I wasn't sure which branch we were merging changes into. Closing now!

@nv-rliu nv-rliu closed this Jun 24, 2024
@nv-rliu nv-rliu deleted the cpp_build_openmpi branch June 27, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants