Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG Implementation K-Truss #4438

Merged

Conversation

jnke2016
Copy link
Contributor

@jnke2016 jnke2016 commented May 23, 2024

This PR adds an MG implementation of K-Truss leveraging the C API

closes #3588

@jnke2016 jnke2016 requested a review from a team as a code owner May 23, 2024 16:59
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Joseph, looks good overall. I just have some minor requests.

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 24, 2024
@rlratzel rlratzel added this to the 23.06 milestone May 29, 2024
@rlratzel rlratzel changed the base branch from branch-24.06 to branch-24.08 May 29, 2024 22:37
@rlratzel rlratzel requested review from a team as code owners May 29, 2024 22:37
@rlratzel rlratzel modified the milestones: 23.06, 23.08 May 29, 2024
@BradReesWork BradReesWork modified the milestones: 23.08, 24.08 May 30, 2024
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like C/C++ changes were transient and are gone now.

Python changes LGTM also

@jnke2016 jnke2016 force-pushed the branch-24.06_mg-python-k-truss branch from cb2280c to 486b92b Compare July 29, 2024 21:01
@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 7b81173 into rapidsai:branch-24.08 Jul 31, 2024
136 of 137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants