-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add PR CI for cugraph-pyg and cugraph-dgl #59
Changes from 18 commits
74b5c95
8b80338
fb5e9e0
84fccbc
74ecbe5
2ed9905
802e46c
4033210
fad3e8b
887e32f
4344fd0
b86bdd3
7897f2f
2c0e654
e718840
7442922
6cc3dec
a421fc9
1202c36
e6c07fa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,10 @@ jobs: | |
- conda-python-tests | ||
- wheel-build-pylibwholegraph | ||
- wheel-tests-pylibwholegraph | ||
- wheel-build-cugraph-dgl | ||
- wheel-tests-cugraph-dgl | ||
- wheel-build-cugraph-pyg | ||
- wheel-tests-cugraph-pyg | ||
secrets: inherit | ||
uses: rapidsai/shared-workflows/.github/workflows/[email protected] | ||
if: always() | ||
|
@@ -104,3 +108,35 @@ jobs: | |
build_type: pull-request | ||
script: ci/test_wheel_pylibwholegraph.sh | ||
matrix_filter: map(select(.ARCH == "amd64")) | ||
wheel-build-cugraph-dgl: | ||
needs: checks | ||
secrets: inherit | ||
uses: rapidsai/shared-workflows/.github/workflows/[email protected] | ||
with: | ||
build_type: pull-request | ||
script: ci/build_wheel_cugraph-dgl.sh | ||
wheel-tests-cugraph-dgl: | ||
needs: [wheel-build-pylibwholegraph, wheel-build-cugraph-dgl, changed-files] | ||
secrets: inherit | ||
uses: rapidsai/shared-workflows/.github/workflows/[email protected] | ||
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python | ||
with: | ||
build_type: pull-request | ||
script: ci/test_wheel_cugraph-dgl.sh | ||
matrix_filter: map(select(.ARCH == "amd64")) | ||
wheel-build-cugraph-pyg: | ||
needs: checks | ||
secrets: inherit | ||
uses: rapidsai/shared-workflows/.github/workflows/[email protected] | ||
with: | ||
build_type: pull-request | ||
script: ci/build_wheel_cugraph-pyg.sh | ||
wheel-tests-cugraph-pyg: | ||
needs: [wheel-build-pylibwholegraph, wheel-build-cugraph-pyg, changed-files] | ||
secrets: inherit | ||
uses: rapidsai/shared-workflows/.github/workflows/[email protected] | ||
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python | ||
with: | ||
build_type: pull-request | ||
script: ci/test_wheel_cugraph-pyg.sh | ||
matrix_filter: map(select(.ARCH == "amd64")) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,8 @@ CPP_CHANNEL=$(rapids-download-conda-from-s3 cpp) | |
|
||
rapids-generate-version > ./VERSION | ||
|
||
sccache --zero-stats | ||
|
||
# TODO: Remove `--no-test` flags once importing on a CPU | ||
# node works correctly | ||
rapids-logger "Begin pylibwholegraph build" | ||
|
@@ -25,4 +27,18 @@ RAPIDS_PACKAGE_VERSION=$(head -1 ./VERSION) rapids-conda-retry mambabuild \ | |
--channel "${CPP_CHANNEL}" \ | ||
conda/recipes/pylibwholegraph | ||
|
||
sccache --show-adv-stats | ||
|
||
RAPIDS_PACKAGE_VERSION=$(head -1 ./VERSION) rapids-conda-retry mambabuild \ | ||
--no-test \ | ||
--channel "${CPP_CHANNEL}" \ | ||
--channel "${RAPIDS_CONDA_BLD_OUTPUT_DIR}" \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need Same for cugraph-dgl below. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're totally right. |
||
conda/recipes/cugraph-pyg | ||
|
||
RAPIDS_PACKAGE_VERSION=$(head -1 ./VERSION) rapids-conda-retry mambabuild \ | ||
--no-test \ | ||
--channel "${CPP_CHANNEL}" \ | ||
--channel "${RAPIDS_CONDA_BLD_OUTPUT_DIR}" \ | ||
conda/recipes/cugraph-dgl | ||
|
||
rapids-upload-conda-to-s3 python |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,46 +4,36 @@ | |
set -eoxu pipefail | ||
|
||
package_name="cugraph-pyg" | ||
package_dir="python/cugraph-pyg" | ||
|
||
python_package_name=$(echo ${package_name}|sed 's/-/_/g') | ||
|
||
mkdir -p ./dist | ||
RAPIDS_PY_CUDA_SUFFIX="$(rapids-wheel-ctk-name-gen ${RAPIDS_CUDA_VERSION})" | ||
|
||
# Download wheels built during this job. | ||
RAPIDS_PY_WHEEL_NAME="pylibcugraph_${RAPIDS_PY_CUDA_SUFFIX}" rapids-download-wheels-from-s3 ./local-deps | ||
RAPIDS_PY_WHEEL_NAME="cugraph_${RAPIDS_PY_CUDA_SUFFIX}" rapids-download-wheels-from-s3 ./local-deps | ||
python -m pip install ./local-deps/*.whl | ||
|
||
# use 'ls' to expand wildcard before adding `[extra]` requires for pip | ||
# Download the pylibwholegraph and cugraph-pyg built in the previous step | ||
RAPIDS_PY_WHEEL_NAME="pylibwholegraph_${RAPIDS_PY_CUDA_SUFFIX}" rapids-download-wheels-from-s3 ./local-deps | ||
RAPIDS_PY_WHEEL_NAME="${package_name}_${RAPIDS_PY_CUDA_SUFFIX}" RAPIDS_PY_WHEEL_PURE="1" rapids-download-wheels-from-s3 ./dist | ||
# pip creates wheels using python package names | ||
python -m pip install $(ls ./dist/${python_package_name}*.whl)[test] | ||
|
||
# RAPIDS_DATASET_ROOT_DIR is used by test scripts | ||
export RAPIDS_DATASET_ROOT_DIR="$(realpath datasets)" | ||
|
||
# Used to skip certain examples in CI due to memory limitations | ||
export CI_RUN=1 | ||
|
||
# determine pytorch and pyg sources | ||
if [[ "${CUDA_VERSION}" == "11.8.0" ]]; then | ||
PYTORCH_URL="https://download.pytorch.org/whl/cu118" | ||
PYG_URL="https://data.pyg.org/whl/torch-2.1.0+cu118.html" | ||
PYG_URL="https://data.pyg.org/whl/torch-2.3.0+cu118.html" | ||
else | ||
PYTORCH_URL="https://download.pytorch.org/whl/cu121" | ||
PYG_URL="https://data.pyg.org/whl/torch-2.1.0+cu121.html" | ||
PYG_URL="https://data.pyg.org/whl/torch-2.3.0+cu121.html" | ||
fi | ||
rapids-logger "Installing PyTorch and PyG dependencies" | ||
rapids-retry python -m pip install torch==2.1.0 --index-url ${PYTORCH_URL} | ||
rapids-retry python -m pip install "torch-geometric>=2.5,<2.6" | ||
rapids-retry python -m pip install \ | ||
ogb \ | ||
pyg_lib \ | ||
torch_scatter \ | ||
torch_sparse \ | ||
tensordict \ | ||
-f ${PYG_URL} | ||
|
||
# echo to expand wildcard before adding `[extra]` requires for pip | ||
python -m pip install \ | ||
-v \ | ||
--extra-index-url "${PYTORCH_URL}" \ | ||
--find-links "${PYG_URL}" \ | ||
"$(echo ./local-deps/pylibwholegraph_${RAPIDS_PY_CUDA_SUFFIX}*.whl)" \ | ||
"$(echo ./dist/cugraph_pyg_${RAPIDS_PY_CUDA_SUFFIX}*.whl)[test]" | ||
|
||
# RAPIDS_DATASET_ROOT_DIR is used by test scripts | ||
export RAPIDS_DATASET_ROOT_DIR="$(realpath datasets)" | ||
|
||
# Used to skip certain examples in CI due to memory limitations | ||
export CI_RUN=1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typically the environment variable We could use that to avoid introducing a separate variable. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah great point! Looks to me like this was carried over from Did that in 1202c36 |
||
|
||
rapids-logger "pytest cugraph-pyg (single GPU)" | ||
pushd python/cugraph-pyg/cugraph_pyg | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need both of these paths? Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, there's an opportunity to simplify here.
I added
dataset/
because I saw files created atpython/cugraph-pyg/cugraph_pyg/dataset/
when running thecugraph-pyg
examples locally.Looks like that comes from here: https://github.com/snap-stanford/ogb/blob/f631af76359c9687b2fe60905557bbb241916258/ogb/nodeproppred/dataset.py#L13
I just pushed changes writing all those datasets to
datasets/
instead, so we don't need to have both rules in gitignore.