[WIP] Null support for hash-based groupby #460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad/libgdf into fea-ext-null-suport-hash-groupby
…re ignored, unless all of the values for a given key are NULL.
…omicOrs to avoid race conditions.
…rnel to rearrange the validity bits of the aggregation output column after sorting the results.
…ut validity mask during the extraction kernel.
…f the AVG aggregator will get set correctly.
… isn't allocated.
…ion output can never be Null. Instead, an aggregation of all NULLs for Count will just return 0.
…f build aggregation table.
… Count value before doing the division.
jrhemstad
added
2 - In Progress
|
Closing due to discussions with @kkraus14 and @williamBlazing about what the desired behavior is for nulls with groupby. Null support will be re-added once groupby has been refactored for single-pass multi-aggregator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was migrated from the old repo: rapidsai/libgdf#140
It adds support for NULL values to the hash-based groupby implementation.
The build_aggregation_table kernel was updated such that if a row is invalid, then it is not inserted into the hash table.