Follow up making Python tests more deterministic #17272
Open
+7
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
Matt711
approved these changes
Nov 7, 2024
galipremsagar
approved these changes
Nov 7, 2024
jameslamb
approved these changes
Nov 7, 2024
vyasr
approved these changes
Nov 8, 2024
| # Check for usage of default_rng without seeding | ||
| default_rng\(\)| | ||
| # Check for usage of np.random.seed | ||
| np.random.seed\( |
There was a problem hiding this comment.
Should we keep this without the parenthesis to forbid usage of np.random.seed in favor of the newer default_rng API?
There was a problem hiding this comment.
Ah interesting, NPY002 allows the np.random.seed callable to exist but complains when it's called. Sure I'll add this back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing comments in https://github.com/rapidsai/cudf/pull/17008/files#r1823318321 and https://github.com/rapidsai/cudf/pull/17008/files#r1823318898
Didn't touch the
_fuzz_testingdirectory because maybe we don't want that to be deterministic?Checklist