Raise errors on specific types of fallback in cudf.pandas
#17268
+123
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt711
added
feature request
github-actions
bot
added
Python
vyasr
requested changes
Nov 8, 2024
| @@ -881,12 +883,36 @@ def _assert_fast_slow_eq(left, right): | |||
| assert_eq(left, right) | |||
|
|
|||
|
|
|||
| class ProxyFallbackError(Exception): | |||
| class FallbackError(Exception): | |||
There was a problem hiding this comment.
For debugging purposes it might be helpful to store func.__name__ from _fast_slow_function_call into the exception.
| """Raised when fallback occurs""" | ||
|
|
||
| pass | ||
|
|
||
|
|
||
| class OOMFallbackError(FallbackError): | ||
| """Warns when cuDF produces a MemoryError or an rmm.RMMError""" |
There was a problem hiding this comment.
All the docstrings should say "Raises" instead of Warns".
| raise OOMFallbackError( | ||
| "Out of Memory Error. Falling back to the slow path. " | ||
| f"The exception was {err}." | ||
| ) |
There was a problem hiding this comment.
I would decorate all of these raises with a from err so that we get the full exception chain (see the docs on the from clause if you're not familiar).
| "mock_mean, err, match_str", | ||
| [ | ||
| ( | ||
| mock_mean_memory_error, |
There was a problem hiding this comment.
Since these are all single-use functions I'd suggest using lambdas instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #14975
Checklist