Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move strings/numeric convert benchmarks to nvbench #17255

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Moves the cpp/benchmarks/string/convert_numerics.cpp and cpp/benchmarks/string/convert_fixed_point.cpp benchmark implementations from google-bench to nvbench.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 6, 2024
@davidwendt davidwendt self-assigned this Nov 6, 2024
@davidwendt davidwendt requested a review from a team as a code owner November 6, 2024 17:19
@github-actions github-actions bot added the CMake CMake build issue label Nov 6, 2024
@vyasr
Copy link
Contributor

vyasr commented Nov 7, 2024

/merge

@rapids-bot rapids-bot bot merged commit e29e0ab into rapidsai:branch-24.12 Nov 7, 2024
102 checks passed
@davidwendt davidwendt deleted the strings-numeric-nvbench branch November 7, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants