Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional column_order in JSON reader #17029
Add optional column_order in JSON reader #17029
Changes from 7 commits
1b6ca58
e0c373a
732f234
ffdd817
02e8ab3
ac05ae9
f10d9c2
71b4142
c8e223d
1c871a8
9297b7e
eb9f8fc
9e31b71
82cf186
105250b
1a7a99c
fcd8e3c
15ef1d5
b2dd7cd
2272f72
e8e1c28
0bfe85e
da24f1d
7e31f91
83b979c
a5442b9
4b82cf6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above we have
if (prune_columns and found_col == std::end
thus here if!prune_columns
then we still havefound_col == std::end
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added
prune_columns
condition tocol_order
decision. This case won't happen.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we throw if
options.is_enabled_prune_columns()
isfalse
but column order is given? The users may want to specify column order but they may forget to enable prune column.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible, the user wants to prune column, but maintain the order as in json file. that's why that throw was not added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still correct? Now strings columns no longer have
chars
child.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #17240.