Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposed stream-ordering to join API #16793

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Exposed stream-ordering to join API #16793

merged 1 commit into from
Sep 20, 2024

Conversation

lamarrr
Copy link
Contributor

@lamarrr lamarrr commented Sep 11, 2024 •
edited
Loading

Description

Adds stream ordering to the public join APIs:

  • inner_join
  • left_join
  • full_join
  • left_semi_join
  • left_anti_join
  • cross_join
  • conditional_inner_join
  • conditional_left_join
  • conditional_full_join
  • conditional_left_semi_join
  • conditional_left_anti_join
  • mixed_inner_join
  • mixed_left_join
  • mixed_full_join
  • mixed_left_semi_join
  • mixed_left_anti_join
  • mixed_inner_join_size
  • mixed_left_join_size
  • conditional_inner_join_size
  • conditional_left_join_size
  • conditional_left_semi_join_size
  • conditional_left_anti_join_size

closes #16792
follows up #13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 11, 2024
@lamarrr lamarrr marked this pull request as ready for review September 11, 2024 13:48
@lamarrr lamarrr requested a review from a team as a code owner September 11, 2024 13:48
@lamarrr lamarrr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 11, 2024
@lamarrr lamarrr mentioned this pull request Sep 11, 2024
Open
@github-actions github-actions bot added the CMake CMake build issue label Sep 16, 2024
@lamarrr
Copy link
Contributor Author

lamarrr commented Sep 16, 2024

/ok to test

@lamarrr
Copy link
Contributor Author

lamarrr commented Sep 17, 2024

/ok to test

@lamarrr
Copy link
Contributor Author

lamarrr commented Sep 20, 2024

/merge

@rapids-bot rapids-bot bot merged commit 69ab988 into rapidsai:branch-24.10 Sep 20, 2024
98 checks passed
@lamarrr lamarrr deleted the join-stream-ordering branch September 20, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmattione-nvidia pmattione-nvidia pmattione-nvidia approved these changes

@davidwendt davidwendt davidwendt approved these changes

@ttnghia ttnghia ttnghia approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Expose stream-ordering to join APIs
4 participants
@lamarrr @ttnghia @davidwendt @pmattione-nvidia