Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Check for integer overflows when creating scalar form python int #16140

Merged
merged 5 commits into from
Jul 15, 2024
Merged

API: Check for integer overflows when creating scalar form python int #16140

merged 5 commits into from
Jul 15, 2024

Commits on Jul 12, 2024

  1. API: Change Scalar to raise for invalid Python values 

    This aligns with NumPy, which deprecated this since a while and
raises an error now, for example for `Scalar(-1, dtype=np.uint8)`.

Necessary to ensure we give the right errors when promotion doesn't
up-cast based on values.
    @seberg
    seberg committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2174f56 View commit details
    Browse the repository at this point in the history

  2. TST: Add test to check scalar conversion behavior for python ints

    @seberg
    seberg committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    14b9a09 View commit details
    Browse the repository at this point in the history

  3. MAINT: Use int8(-1) as default categorical as np.uint8(-1) fails

    @seberg
    seberg committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2e1eb4a View commit details
    Browse the repository at this point in the history

  4. TST: Fixup test mistake

    @seberg
    seberg committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    174f2b3 View commit details
    Browse the repository at this point in the history

  5. Use packaging.version for numpy version check as suggested

    @seberg
    seberg committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    39d240f View commit details
    Browse the repository at this point in the history