Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Centos7 support #15608

Merged
merged 7 commits into from
May 2, 2024
Merged

Drop Centos7 support #15608

merged 7 commits into from
May 2, 2024

Conversation

NvTimLiu
Copy link
Contributor

To fix #15583

We plan to drop CentOS 7 (which uses glibc 2.17) RAPIDS 24.06. The java/ci/Dockerfile.centos7, refor or to :

https://docs.rapids.ai/notices/rsn0037/

rapidsai/build-planning#23

Change to run build in Rocky8 docker container

Checklist

@NvTimLiu
Drop Centos7 support
ecf794e 
To fix rapidsai#15583

Change to run build in Rocky8 docker container

Signed-off-by: Tim Liu <[email protected]>
@NvTimLiu NvTimLiu self-assigned this Apr 28, 2024
@NvTimLiu NvTimLiu requested a review from a team as a code owner April 28, 2024 16:00
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 28, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Java Affects Java cuDF API. label Apr 28, 2024
@NvTimLiu NvTimLiu added ci breaking Breaking change improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed breaking Breaking change labels Apr 28, 2024
jlowe
jlowe approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits otherwise lgtm.

java/ci/Dockerfile.rocky Outdated Show resolved Hide resolved
java/ci/Dockerfile.rocky Outdated Show resolved Hide resolved
@NvTimLiu
Update build scripts
7472d87 
Signed-off-by: Tim Liu <[email protected]>
@NvTimLiu NvTimLiu requested a review from a team as a code owner April 29, 2024 14:52
@github-actions github-actions bot removed the ci label Apr 29, 2024
bdice
bdice reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo -- otherwise LGTM.

build.sh Outdated Show resolved Hide resolved
bdice
bdice reviewed Apr 29, 2024
View reviewed changes
build.sh Outdated Show resolved Hide resolved
bdice
bdice approved these changes Apr 29, 2024
View reviewed changes
java/ci/Dockerfile.rocky Show resolved Hide resolved
@bdice bdice mentioned this pull request Apr 29, 2024
Closed
24 tasks
@bdice
Copy link
Contributor

bdice commented Apr 30, 2024

/ok to test

@NvTimLiu
fix typo
285329f 
Signed-off-by: Tim Liu <[email protected]>
@NvTimLiu
Copy link
Contributor Author

/ok to test

@NvTimLiu
Copy link
Contributor Author

NvTimLiu commented May 1, 2024

@rapidsai/ops-codeowners can you help review? Thanks!

@bdice
Copy link
Contributor

bdice commented May 2, 2024 •
edited
Loading

I merged the upstream and resolved a merge conflict from #15619. I also pinged ops for a review, after which this should be ready to merge.

raydouglass
raydouglass reviewed May 2, 2024
View reviewed changes
Copy link
Member

@raydouglass raydouglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

raydouglass
raydouglass approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@raydouglass raydouglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it out of order, so approved to remove any blockers.

@raydouglass
Copy link
Member

/okay to test

@bdice
Copy link
Contributor

bdice commented May 2, 2024

Thanks @NvTimLiu!

@bdice
Copy link
Contributor

bdice commented May 2, 2024

/merge

@rapids-bot rapids-bot bot merged commit 2ee0219 into rapidsai:branch-24.06 May 2, 2024
70 checks passed
@NvTimLiu NvTimLiu mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@raydouglass raydouglass raydouglass approved these changes

@jlowe jlowe jlowe approved these changes

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008

@sameerz sameerz Awaiting requested review from sameerz

@ttnghia ttnghia Awaiting requested review from ttnghia

Assignees

@NvTimLiu NvTimLiu

Labels
improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Drop CentOS7 support for java/ci docker build
4 participants
@NvTimLiu @bdice @raydouglass @jlowe