Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run IO tests for Dask-cuDF #14327

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Run IO tests for Dask-cuDF #14327

merged 3 commits into from
Oct 25, 2023

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented Oct 25, 2023 •
edited
Loading

Description

We are not currently running any IO tests for dask_cudf in CI. This PR should correct this. It also modifies a test that would be failing due to #14326

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added bug Something isn't working 2 - In Progress Currently a work in progress dask Dask issue non-breaking Non-breaking change labels Oct 25, 2023
@rjzamora rjzamora self-assigned this Oct 25, 2023
@rjzamora rjzamora requested review from a team as code owners October 25, 2023 15:46
@github-actions github-actions bot added Python Affects Python cuDF API. ci labels Oct 25, 2023
@rjzamora
Copy link
Member Author

cc @galipremsagar (This is why we have not been catching the recent dask_cudf failures in CI)

@rjzamora @galipremsagar
Update ci/test_wheel_dask_cudf.sh
04a4bcf 
Co-authored-by: GALI PREM SAGAR <[email protected]>
galipremsagar
galipremsagar approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this @rjzamora !

@rjzamora rjzamora added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 25, 2023
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Oct 25, 2023
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 76bdb82 into rapidsai:branch-23.12 Oct 25, 2023
56 of 57 checks passed
@rjzamora rjzamora deleted the unskip-dask-cudf-tests branch October 25, 2023 21:57
@galipremsagar galipremsagar mentioned this pull request Oct 27, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Oct 27, 2023
@galipremsagar
Enable dask_cudf/io pytests in CI (#14338)
751370e 
@rjzamora recently identified and fixed(#14327) an issue where `dask_cudf/io` pytests weren't being run in ci, however, this was fixed for wheels pytests. This PR fixes the same issue in `conda` pytests.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #14338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice left review comments

@galipremsagar galipremsagar galipremsagar approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees

@rjzamora rjzamora

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rjzamora @galipremsagar @raydouglass @bdice