-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose stream parameter in public strings replace APIs #14261
Expose stream parameter in public strings replace APIs #14261
Conversation
So will the paradigm change in cudf to pulling out the detail namespace implementation into the main namespace since we no longer have the stream and mr hidden or will we keep the redirection into the detail namespace? |
No, the public APIs will continue to have the nvtx range calls to help with profiling. |
/merge |
Description
Add stream parameter to public APIs:
cudf::strings::replace()
(x2)cudf::strings::replace_slice()
cudf::strings::replace_re()
(x2)cudf::strings::replace_with_backrefs()
Also cleaned up some of the doxygen comments and added stream-tests.
Reference #13744
Checklist