Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assert failure for range window functions #14168

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Fix assert failure for range window functions #14168

merged 2 commits into from
Sep 23, 2023

Commits on Sep 22, 2023

  1. Fix assert failure for range window functions 

    Fixes rapidsai#13855.

This commit fixes an erroneous assert check in range window functions,
where the wrong data-type is checked for timestamp order-by columns.

For timestamps, it's the duration::rep type that should be checked,
when accessing the order by column.

This fix allows ROLLING_TEST to complete correctly, in DEBUG mode.
    @mythrocks
    mythrocks committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    97a4022 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-23.10' into fix-window-orderby-assert

    @PointKernel
    PointKernel authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    8716aa1 View commit details
    Browse the repository at this point in the history