Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support callables in DataFrame.assign #14142

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Support callables in DataFrame.assign #14142

merged 2 commits into from
Sep 22, 2023

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Sep 20, 2023 •
edited
Loading

Description

While here, change the way the initial copied frame is constructed:
callables are allowed to refer to columns already in the dataframe,
even if they overwrite them.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 20, 2023
@mroeschke
Copy link
Contributor

#12936?

@wence-
Support callables in DataFrame.assign
7804587 
While here, change the way the initial copied frame is constructed:
callables are allowed to refer to columns already in the dataframe,
even if they overwrite them.

- Closes rapidsai#12936
@wence- wence- marked this pull request as ready for review September 21, 2023 13:43
@wence- wence- requested a review from a team as a code owner September 21, 2023 13:43
@wence- wence- requested review from vyasr and isVoid September 21, 2023 13:43
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 21, 2023
@wence-
Copy link
Contributor Author

wence- commented Sep 21, 2023

#12936?

Thanks, yes, added.

@wence-
Copy link
Contributor Author

wence- commented Sep 22, 2023

/merge

@rapids-bot rapids-bot bot merged commit a6d014e into rapidsai:branch-23.10 Sep 22, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Support UDF expression for referencing self in assign
2 participants
@wence- @mroeschke